Skip to content

Add coloring of basis functions#176

Closed
djukic14 wants to merge 2 commits into
krcools:masterfrom
djukic14:feature/colors
Closed

Add coloring of basis functions#176
djukic14 wants to merge 2 commits into
krcools:masterfrom
djukic14:feature/colors

Conversation

@djukic14

Copy link
Copy Markdown
Contributor

Added coloring of basis functions.
Added multithreading based on coloring.
New progressbar.
Multithreading for computation of potential.

@krcools

krcools commented Dec 5, 2025

Copy link
Copy Markdown
Owner

I added the integration and a test at the level of assemble. What are your thoughts?

@djukic14

djukic14 commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

I think it looks great. I was wondering if you'd consider integrating @tasks with a scheduler in the :dofsplitting variant? It might also be worth exploring using OhMyThreads chunks() for splitting the basis functions. This could help unify the API between :dofsplitting and :cellcoloring, making the interface more consistent across both approaches. That said, I completely understand if you'd prefer to stick with the current implementation

@krcools

krcools commented Dec 5, 2025

Copy link
Copy Markdown
Owner

Thanks. I completely agree with fixing the dofsplitting code to allow for robust task migration. This was next on the agenda. I will need to do this as well for the quasi-local integral operators where a non-trivial reduction step is involved in order to produce the final matrix. I'll take the cue from how you dealt with task-local storage!

@krcools

krcools commented Dec 5, 2025

Copy link
Copy Markdown
Owner

I want to merge but there is a conflict in runtests.jl

Not sure how to proceed using just rebase (as opposed to merge). What is the prescribed procedure? Copy the branch, rebase, and start a new PR?

@krcools krcools closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants